Skip to content
GitLab
  1. 27 Aug, 2016 1 commit
    • Rahul Bedarkar's avatar
      tests: define __STDC_LIMIT_MACROS · 1dc83fd7
      Rahul Bedarkar authored 
      With glibc 2.16, we get following build error when building jack2:

  [193/247] cxx: tests/iodelay.cpp -> build/tests/iodelay.cpp.4.o
  ../tests/iodelay.cpp:171:43: error: 'UINT32_MAX' was not declared in this scope
  ../tests/iodelay.cpp:171:55: error: 'UINT32_MAX' was not declared in this scope
  ../tests/iodelay.cpp:172:44: error: 'UINT32_MAX' was not declared in this scope
  ../tests/iodelay.cpp:172:56: error: 'UINT32_MAX' was not declared in this scope

In glibc 2.17 or older version, Header <stdint.h> defines these macros
for C++ only if explicitly requested by defining __STDC_LIMIT_MACROS.

We can't use <cstdint> since it requires C++11 standard.

This build issue found by Buildroot autobuilder.
http://autobuild.buildroot.net/results/369/369ce208ffea43dad75ba0a13469159b341e3bf5/



Signed-off-by: default avatarRahul Bedarkar <rahul.bedarkar@imgtec.com>
      1dc83fd7
  3. 11 Jun, 2016 1 commit
    • Adrian Knoth's avatar
      Fix initialization in test/iodelay.cpp · ff1ed2c4
      Adrian Knoth authored 
      jack_latency_range_t is

struct _jack_latency_range {
    jack_nframes_t min;
    jack_nframes_t max;
};

and jack_nframes_t is

typedef uint32_t        jack_nframes_t;

so it's unsigned. Initialising it with -1 is invalid (at least in C++14). We cannot use {0, 0}, because latency_cb has

   jack_latency_range_t range;
   range.min = range.max = 0;
   if ((range.min != capture_latency.min) || (range.max !=
       capture_latency.max)) {
       capture_latency = range;
   }

so we must not have {0, 0}, otherwise the condition would never be true.

Using UINT32_MAX should be equivalent to the previous -1.
      ff1ed2c4
  5. 08 Nov, 2012 1 commit
  7. 04 Nov, 2011 1 commit
  9. 15 Jul, 2011 1 commit
  11. 13 Jul, 2011 1 commit
  13. 11 Mar, 2011 1 commit
  15. 09 Mar, 2011 2 commits
  17. 25 Nov, 2008 2 commits
  19. 16 May, 2008 1 commit
  21. 15 May, 2008 1 commit
  23. 03 Sep, 2006 3 commits